-
Notifications
You must be signed in to change notification settings - Fork 22
Improve “Get Tickets” Button Design in Navigation to Match UI Style ✨ #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inpycon2025 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hey, @farhaanbukhsh, @anistark! Review this PR! |
@dhanushk-offl Overall looks ok. But I feel the font seem a bit larger than rest of navbar items right now. and so, feels a bit off. In mobile view, The button is one side. Might look better with full width, in-line with rest of the items. |
I think Design WG can take a better call on this, |
@dhanushk-offl could you please add before and after screenshot for this change for both desktop and mobile version? |
Before: |
@dhanushk-offl @ashish10677 the version of the button looks perfect as it is. I don’t think we need improvements. |
@shabnam701 Please check mobile version as well. Feels off. ![]() Might look better with full width button in mobile view. |
@anistark we can go with this for mobile view. |
@farhaanbukhsh can we merge it? |
@anistark, for mobile view, it is okay, but with the growing navbar, I don't feel comfortable with this change. |
Changes Made:
Reason:
The "Get Tickets" button is a key CTA on our homepage. And I feel the previous design looked out of place and didn’t match the rest of our UI, which could affect user engagement. The updated design enhances consistency, improves visibility, and makes it more appealing to users.